Luau Implementation #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bennn
reviewed
Feb 4, 2025
bennn
reviewed
Feb 4, 2025
bennn
reviewed
Feb 4, 2025
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
dibrinsofor
commented
Feb 13, 2025
Signed-off-by: Dibri Nsofor <[email protected]>
bennn
requested changes
Feb 14, 2025
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
Signed-off-by: Dibri Nsofor <[email protected]>
dibrinsofor
commented
Mar 2, 2025
|
This is all set to be merged. Maybe a final review @hanwenguo |
bennn
requested changes
May 19, 2025
| return x is String | ||
| ``` | ||
|
|
||
| Since Luau, does not currently provide a direct way to connect a function |
| iterable. Other notable mentions are `~=` for the not operator and `_` as a | ||
| prefix to silence warnings to unused definitions. | ||
|
|
||
| Example: `#x` |
There was a problem hiding this comment.
Put this code example right below the sentence about length. It's not clear up above what the syntax actually is for getting the length of an iterable.
|
|
||
| > Q. Are any examples inexpressible? Why? | ||
|
|
||
| No. |
There was a problem hiding this comment.
This PR doesn't implement the examples! Either add an implementation and update this section, or replace the answers here with "N/A: the examples are future work.".
|
|
||
| A Table in Luau is the base data structure for constructing complex objects or | ||
| organizing data. This implementation adopts `tables` for Lists, Structs and to | ||
| construct aliases for `Pairs` and `Tuples`. |
There was a problem hiding this comment.
Pairs and Tuples should be Pair and Triple
| -- Example alias | ||
| -- success | ||
| function _alias_success_f(x: unknown): unknown | ||
| local y = typeof(x) == "number" |
There was a problem hiding this comment.
typo: number should be string to match the benchmark.
|
|
||
| -- failure | ||
| function _predicate_checked_failure_f(x: string | number | boolean): never | ||
| -- not representable in Luau (v0.657) |
| end | ||
|
|
||
| function _predicate_checked_failure_g(x: string | number | boolean): never | ||
| -- not representable in Luau (v0.657) |
| error("not representable in Luau (v0.657)") | ||
| end | ||
|
|
||
| -- Example object_properties |
| return 0 | ||
| end | ||
| return x + 1 | ||
| end |
| @@ -19,6 +20,7 @@ The tested versions are: | |||
| | Flow | 0.245.2 | See [`Flow/package-lock.json`](https://github.com/utahplt/ot-benchmark/blob/main/Flow/package-lock.json) | | |||
| | Pyright | 1.1.389 | See [`Pyright/package-lock.json`](https://github.com/utahplt/ot-benchmark/blob/main/Pyright/package-lock.json) | | |||
| | mypy | 1.13.0 | See [`mypy/requirements.txt`](https://github.com/utahplt/ot-benchmark/blob/main/mypy/requirements.txt) | | |||
| | Luau | 0.657 | [Luau 0.657](https://github.com/luau-lang/luau/releases/tag/0.657) | | |||
There was a problem hiding this comment.
add indentation so the columns match previous rows
|
Also, this ought to have a (In the future we should just have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Luau implementation of the ifT benchmark with datasheet.